-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: derive more #80
Conversation
Signed-off-by: Cheng JIANG <alex_cj96@foxmail.com>
derive let mut p = Personalization::default();
p.add_to(...) which eventually fixes #79 |
@gsquire hi could you have a look, thanks |
Hey, @GopherJ. I am currently moving out of state so it'll be a little while before I can review. I'm sorry for the delay! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this sat for a bit. I should be able to respond much quicker now after the new year. Just one minor comment and then we can land this.
|
||
[dev-dependencies] | ||
tokio = { version = "0.3", features = ["full"] } | ||
|
||
[features] | ||
default = ["native-tls", "blocking"] | ||
default = ["native-tls", "async"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave the blocking
option as default and let people opt into using async
.
Also, is there any way to undo the formatting that changed here?
Closing, see #79 (comment). |
Signed-off-by: Cheng JIANG alex_cj96@foxmail.com
close: #79